Add village and other fields based on kobo form changes #171
Conversation
| @@ -86,6 +86,8 @@ export class IncidentDto { | |||
| @IsOptional() @IsNumberString() readonly 'group_pk03i04/group_ub2hp14/CraftDam'?: string; | |||
| @IsOptional() @IsNumberString() readonly 'group_gh6ag70/group_na4yi04/CropAff'?: string; | |||
| @IsOptional() @IsNumberString() readonly 'group_gh6ag70/group_na4yi04/CropDam'?: string; | |||
| @IsOptional() @IsNumberString() readonly 'group_gh6ag70/group_az7bv13/integer_ws0la67'?: string; | |||
There was a problem hiding this comment.
@wadhwamatic I think they should update these names before they get integrated in other apps to stay consistent with the rest
There was a problem hiding this comment.
agreed. I'll have them update it in kobo
apps/frontend/translations/en.json
Outdated
| @@ -211,8 +211,13 @@ | |||
| "NumWareHDam": "Damaged", | |||
| "NumCraftAff": "Affected", | |||
| "NumCraftDam": "Damaged", | |||
| "integer_ws0la67": "Affected", | |||
There was a problem hiding this comment.
These do not seem to appear in Flood, should they be under Incident instead?
| @@ -30,6 +30,7 @@ export const IncidentMapping: MappingTypes = { | |||
| drowning: '10', | |||
| collapse: '11', | |||
| weapon: '12', | |||
| shipwreck: '13', | |||
There was a problem hiding this comment.
I also saw a value 14 in the files you shared, should we add it too?
There was a problem hiding this comment.
Looks like it's also shipwreck (based on google trad) so I'm a bit confused
| @@ -132,6 +134,8 @@ export const incidentSpecificKeys = { | |||
| [IncidentSpecific.CraftDam]: 'group_pk03i04/group_ub2hp14/CraftDam', | |||
| [IncidentSpecific.CropAff]: 'group_gh6ag70/group_na4yi04/CropAff', | |||
| [IncidentSpecific.CropDam]: 'group_gh6ag70/group_na4yi04/CropDam', | |||
| [IncidentSpecific.integer_ws0la67]: 'group_gh6ag70/group_az7bv13/CropAff', | |||
There was a problem hiding this comment.
The values on the right should be the corresponding keys from the kobo forms
|
Build succeeded and deployed at https://wfp-dmp-171.surge.sh |
ericboucher
changed the title
Add new village field to the three forms
Update Incident report to add a new shipwreck incident type and factory counts
Update Flood report to add 3 new fields
Update Readme to guide users through column additions